Allow specification of targets in VirtualServer's spec.externalDNS field
#7009
Conversation
github-actions
bot
added
enhancement
✅ Deploy Preview will be available once build job completes!
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7009 +/- ##
==========================================
+ Coverage 52.73% 52.77% +0.04%
==========================================
Files 89 89
Lines 20824 20873 +49
==========================================
+ Hits 10981 11016 +35
- Misses 9389 9399 +10
- Partials 454 458 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| if count > 1 { | ||
| return nil, "", errors.New("multiple record types (A, AAAA, CNAME) detected; must be homogeneous") |
There was a problem hiding this comment.
Having both A & AAAA records is a valid use case
There was a problem hiding this comment.
That's a valid point. However, given that the VirtualServer.spec.externalDNS object includes a recordType field, indicating that each DNS entry must be homogeneous, it’s reasonable to expect this limitation to a single record type.
| var recordA, recordAAAA, recordCNAME bool | ||
|
|
||
| for _, t := range targets { | ||
| if errMsg := validation.IsValidIP(field.NewPath(""), t); len(errMsg) == 0 { |
There was a problem hiding this comment.
IsValidIP is a wrapper for netutils.ParseIPSloppy(), there is probably no need to call it twice
|
@j1m-ryan is there any update on this ? should we expect this to be merged soon ? that will be great feature. |
|
without investigating in the whole code... if in the config-map is the parameter data: a new virtual-server gets the external ip an existing won't update this ip if changed. kind regards |
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
github-actions
bot
added
stale
Proposed changes
Implements #5196
Checklist
Before creating a PR, run through this checklist and mark each as complete.